🔇 Fix sh logs too verbose #3048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
force-pushed
the
feature/fix_sh_log_too_verbose
branch
from
f3a09e5 to
7745526
Compare
When setuptools is not present and the root logger has no handlers, Wheels would configure the root logger with DEBUG level, refs: - https://github.com/pypa/wheel/blob/0.44.0/src/wheel/util.py - https://github.com/pypa/wheel/blob/0.44.0/src/wheel/_setuptools_logging.py Both of these conditions are met in our CI, leading to very verbose and unreadable `sh` logs. Patching it prevents that.
AndreMiras
force-pushed
the
feature/fix_sh_log_too_verbose
branch
from
7745526 to
a85d24e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setuptools is not present and the root logger has no handlers, Wheels would configure the root logger with DEBUG level, refs:
Both of these conditions are met in our CI, leading to very verbose and unreadable
shlogs. Patching it prevents that.